[PATCH] D102912: [libunwind] AARCH64 use inline assembly for pointer authentication

[Maksim Kita via Phabricator via llvm-commits]

kitaisreal marked 2 inline comments as done.
kitaisreal added inline comments.


================
Comment at: libunwind/src/DwarfInstructions.hpp:229
+                       "mov x16, %x1;\n\t"
+                       "hint %[key];\n\t"
+                       "mov %0, x17\n\t"
----------------
MaskRay wrote:
> pcc wrote:
> > kitaisreal wrote:
> > > MaskRay wrote:
> > > > Just use `hint 0xe`?
> > > Discussed in previous comments that it make sense to be more specific and use constant.
> > (I would vote for the way you had this originally, FWIW.)
> `"hint 0xe;" // autib1716`
Updated to previous revision.


================
Comment at: libunwind/src/DwarfInstructions.hpp:229
+                       "mov x16, %x1;\n\t"
+                       "hint %[key];\n\t"
+                       "mov %0, x17\n\t"
----------------
kitaisreal wrote:
> MaskRay wrote:
> > pcc wrote:
> > > kitaisreal wrote:
> > > > MaskRay wrote:
> > > > > Just use `hint 0xe`?
> > > > Discussed in previous comments that it make sense to be more specific and use constant.
> > > (I would vote for the way you had this originally, FWIW.)
> > `"hint 0xe;" // autib1716`
> Updated to previous revision.
Updated to previous revision.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102912/new/

https://reviews.llvm.org/D102912