[PATCH] D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands

Wed May 26 12:56:41 PDT 2021

dblaikie added a comment.

In D91722#2782868 <https://reviews.llvm.org/D91722#2782868>, @aheejin wrote:

> In D91722#2774622 <https://reviews.llvm.org/D91722#2774622>, @sbc100 wrote:
>
>> In D91722#2774612 <https://reviews.llvm.org/D91722#2774612>, @jmorse wrote:
>>
>>> In D91722#2774557 <https://reviews.llvm.org/D91722#2774557>, @sbc100 wrote:
>>>
>>>> After the third re-land of this patch we are seeing a crash in the emscripten compiler:  https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket.appspot.com/8846604336499720256/+/steps/Emscripten_testsuite__upstream__other_/0/stdout
>>>
>>> Thanks for the report -- we're out of working hours in the UK timezone and I can't revert myself, if you could revert this for us, please do.
>>
>> We are investigating now.  I looks like this assert only fires in combination with WebAssemlby change that was landed between the 2nd and 3rd re-landing: https://reviews.llvm.org/D102589.  I think we will try to fix forward if we can and if that fails revert either or the other.
>
> This turned out to be a bug in WebAssembly side. We fixed it so nevermind!

Might be handy to include a link to the fix here for context (in case other folks with out of tree backends hit similar issues, etc)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91722/new/

https://reviews.llvm.org/D91722