[PATCH] D103129: [llvm-reduce] Don't delete arguments of debug intrinsics

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

the title/summary needs to be updated



================
Comment at: llvm/test/tools/llvm-reduce/remove-args-dbg-intrinsics.ll:3
+;
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=arguments --test=opt --test-arg=-verify --test-arg=-disable-output --output=%t %s
+; RUN: cat %t | FileCheck %s
----------------
I don't think this is the right test, llvm-reduce already checks that something is verified. The test should be checking that each of the three intrinsics is declared (ignoring the arguments). Look at the other tests in the file for more examples.


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceArguments.cpp:47
+static bool shouldRemoveArguments(const Function &F) {
+  return !F.arg_empty() && F.getIntrinsicID() == Intrinsic::not_intrinsic;
+}
----------------
`F.isIntrinsic()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103129/new/

https://reviews.llvm.org/D103129