[PATCH] D103193: Update documentation for InlineModel features.

[Jacob Hegna via Phabricator via llvm-commits]

jacobhegna updated this revision to Diff 348033.
jacobhegna added a comment.

Change caller -> callee in the last feature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103193/new/

https://reviews.llvm.org/D103193

Files:
  llvm/include/llvm/Analysis/InlineModelFeatureMaps.h


Index: llvm/include/llvm/Analysis/InlineModelFeatureMaps.h
===================================================================
--- llvm/include/llvm/Analysis/InlineModelFeatureMaps.h
+++ llvm/include/llvm/Analysis/InlineModelFeatureMaps.h
@@ -34,11 +34,10 @@
   M(NrCtantParams, "nr_ctant_params",                                          \
     "number of parameters in the call site that are constants")                \
   M(CostEstimate, "cost_estimate", "total cost estimate (threshold - free)")   \
-  M(EdgeCount, "edge_count",                                                   \
+  M(EdgeCount, "edge_count", "total number of calls in the module")            \
+  M(CallerUsers, "caller_users",                                               \
     "number of module-internal users of the caller, +1 if the caller is "      \
     "exposed externally")                                                      \
-  M(CallerUsers, "caller_users",                                               \
-    "number of blocks reached from a conditional instruction, in the caller")  \
   M(CallerConditionallyExecutedBlocks, "caller_conditionally_executed_blocks", \
     "number of blocks reached from a conditional instruction, in the caller")  \
   M(CallerBasicBlockCount, "caller_basic_block_count",                         \
@@ -46,7 +45,8 @@
   M(CalleeConditionallyExecutedBlocks, "callee_conditionally_executed_blocks", \
     "number of blocks reached from a conditional instruction, in the callee")  \
   M(CalleeUsers, "callee_users",                                               \
-    "number of blocks reached from a conditional instruction, in the callee")
+    "number of module-internal users of the callee, +1 if the callee is "      \
+    "exposed externally")
 
 enum class FeatureIndex : size_t {
 #define POPULATE_INDICES(INDEX_NAME, NAME, COMMENT) INDEX_NAME,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103193.348033.patch
Type: text/x-patch
Size: 1880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210526/bbfdc4f9/attachment.bin>