[PATCH] D102912: [libunwind] AARCH64 use inline assembly for pointer authentication

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 26 10:36:08 PDT 2021


pcc added inline comments.


================
Comment at: libunwind/src/DwarfInstructions.hpp:229
+                       "mov x16, %x1;\n\t"
+                       "hint %[key];\n\t"
+                       "mov %0, x17\n\t"
----------------
kitaisreal wrote:
> MaskRay wrote:
> > Just use `hint 0xe`?
> Discussed in previous comments that it make sense to be more specific and use constant.
(I would vote for the way you had this originally, FWIW.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102912/new/

https://reviews.llvm.org/D102912



More information about the llvm-commits mailing list