[PATCH] D103004: [llvm-mc] Add -M to replace -riscv-no-aliases and -riscv-arch-reg-names

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 26 09:53:07 PDT 2021


craig.topper added a comment.

In D103004#2780266 <https://reviews.llvm.org/D103004#2780266>, @jrtc27 wrote:

> In D103004#2780185 <https://reviews.llvm.org/D103004#2780185>, @craig.topper wrote:
>
>> In D103004#2779572 <https://reviews.llvm.org/D103004#2779572>, @frasercrmck wrote:
>>
>>> I've never understood why they're there either so I'm not best-qualified to say. I've never used it when adding my own tests. As @tmatheson said, maybe it's used externally?
>>
>> I'm also not sure why the rvv tests use no-aliases. I think the majority were generated by a tool developed before I get here. I'll ask around internally.
>
> If you conclude they can go, I have the patch ready to push. I could put it in Phab, but I doubt anyone wants to read the 25309 changed lines; the full summary of all the changes is very boring:
>
>   waltham:llvm-project-upstream jrtc4% git diff | grep '^[-+][^-+]' | sort | uniq -c
>     24844 -; CHECK-NEXT:    jalr zero, 0(ra)
>     24844 +; CHECK-NEXT:    ret
>         8 -; CHECK-NEXT:    vl4re8.v v28, (a0)
>         8 +; CHECK-NEXT:    vl4r.v v28, (a0)
>        64 -; CHECK-NEXT:    vl8re8.v v24, (a0)
>        64 +; CHECK-NEXT:    vl8r.v v24, (a0)
>       392 -; RUN:   --riscv-no-aliases < %s | FileCheck %s
>       392 +; RUN:   < %s | FileCheck %s
>         1 -; RUN:   -verify-machineinstrs --riscv-no-aliases < %s \
>         1 +; RUN:   -verify-machineinstrs < %s \

They can go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103004/new/

https://reviews.llvm.org/D103004



More information about the llvm-commits mailing list