[PATCH] D103165: Threading: use independent llvm::thread implementation on Apple platforms to increase stack size
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 26 09:09:51 PDT 2021
dexonsmith added a comment.
I wonder, could this be used to simplify RunSafelyOnThread, and/or llvm_execute_on_thread_impl? I figure all that complexity is because of the same limitation, but maybe it's not something we can fix, since we exposed a libclang API (clang_executeOnThread) that allows specifying a stack size.
I guess one option would be to never use std::thread, and repurpose the guts of llvm_execute_on_thread_impl to implement a cross-platform `llvm::thread` that allows specifying the stack size as an optional constructor parameter (and then change llvm_execute_on_thread to use llvm::thread). WDYT?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103165/new/
https://reviews.llvm.org/D103165
More information about the llvm-commits
mailing list