[PATCH] D102673: [ConstantFolding] Fold constrained arithmetic intrinsics

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:497
+      return true;
+  }
+
----------------
What about "maytrap"? The language reference explicitly calls out constant folding as allowed under "maytrap" since it doesn't introduce any new exceptions.


================
Comment at: llvm/test/CodeGen/PowerPC/vector-constrained-fp-intrinsics.ll:240
+; PC64LE-NEXT:    lxvd2x 0, 0, 3
+; PC64LE-NEXT:    xxswapd 34, 0
 ; PC64LE-NEXT:    blr
----------------
I hate to lose the testing we're currently doing with this file. Can you split out from this file the tests that these changes hit, and then change this existing test to take arguments instead of constants? That way we preserve testing the SDAG but also test that your constant folding works correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102673/new/

https://reviews.llvm.org/D102673