[PATCH] D103139: [AMDGPU] Replace non-kernel function uses of LDS globals by pointers.

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

Use different passes for different things, and optimisations are different from lowering. Those should not be contentious statements in a multipass compiler. Strictly I'm not sure this is an optimisation as it burns cycles to reduce memory, and that's only useful if the saved memory improves occupancy.

I see zero advantages to your single-combined-pass preference and have enumerated disadvantages. Mostly that making it harder to review and to test makes it less likely to work. It also means the tests are fragile, which will cost us when improving the heuristics on which variables to transform.

What are the advantages you see that merit breaking from the default of using multiple passes in a multiple pass compiler?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103139/new/

https://reviews.llvm.org/D103139