[PATCH] D101916: [LoopVectorize] Fix crash for predicated instructions with scalable VF

Caroline via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 26 06:27:45 PDT 2021


CarolineConcatto marked 2 inline comments as done.
CarolineConcatto added a comment.

Thank you @david-arm for the review.
It is quite difficult to get the comments right, but I think that your comment is better than mine
So I've replaced.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5598
+        Msg = "Scalable vectorization not supported for predicated operations "
+              "found in this loop. Using fixed-width vectorization instead.";
+        return false;
----------------
david-arm wrote:
> I wonder if this is potentially misleading as we're not guaranteed to fall back on fixed-width vectorization, particularly if the user applied a C/C++ pragma to the loop?
Ok, I removed the part that used to say that it would rely on a fixed-width vector.
Now it has the same message as the others


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101916/new/

https://reviews.llvm.org/D101916



More information about the llvm-commits mailing list