[PATCH] D103138: [AMDGPU] [IndirectCalls] Don't propagate attributes to address taken functions and their callees

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Going back to remove the attributes feels more confusing than just not setting them in the first place



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp:234-237
+  if (!ModuleCG) {
+    llvm_unreachable("Call graph not valid");
+    return Changed;
+  }
----------------
Just assert, the return is dead


================
Comment at: llvm/test/CodeGen/AMDGPU/propagate-attributes-launch-bounds.ll:7
+
+; CHECK-LABEL: define float @foo() {
+define float @foo() {
----------------
Add a comment that there should be no attribute set


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103138/new/

https://reviews.llvm.org/D103138