[PATCH] D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files.

EsmeYi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 26 03:28:23 PDT 2021


Esme added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:68
 
 # ERROR: The end of the file was unexpectedly encountered
 
----------------
jhenderson wrote:
> I know this was there before, but is this the full error message? I'd expect it to at least say something like: "error: ...". Also, a separate patch, but this error does not follow the LLVM style guide for error messages (it should be "the end", not "The end").
Yes, this should be another follow-up work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103146/new/

https://reviews.llvm.org/D103146



More information about the llvm-commits mailing list