[PATCH] D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:19-22
+  - Name:               .text
+    Address:            0x8
+    Size:               0x8
+    Flags:              [ STYP_TEXT ]
----------------
Nit: here and elsewhere, remove the excessive spacing, as per the inline example.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:62
+
+## Truncate the file to end before the program header table ends.
+# RUN: yaml2obj %s --docnum=3 -o %t-truncate.o
----------------



================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:68
 
 # ERROR: The end of the file was unexpectedly encountered
 
----------------
I know this was there before, but is this the full error message? I'd expect it to at least say something like: "error: ...". Also, a separate patch, but this error does not follow the LLVM style guide for error messages (it should be "the end", not "The end").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103146/new/

https://reviews.llvm.org/D103146