[PATCH] D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option.

Tue May 25 23:17:33 PDT 2021

shchenz accepted this revision.
shchenz added a comment.

LGTM too with some nits.

================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:30
+  - Name:               .bss
+    Address:            0x20
+    Size:               0x0
----------------
nit: two Address?

================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:45
+    Size:               0x46
+    Flags:              [ STYP_DEBUG ]
+
----------------
I understand this is for testing purposes. But `STYP_DEBUG` is specific for stabstrings and `.dwinfo` is specific for dwarf on AIX, I think it is not a good idea to make them together.
Maybe you can use `.debug` section for `STYP_DEBUG`.

================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:49
+
+# RUN: yaml2obj %s --docnum=2 -o %t-longname.o
+# RUN: llvm-objdump --section-headers %t-longname.o \
----------------
Nit: should we put the RUN lines together at the front of this file?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103079/new/

https://reviews.llvm.org/D103079