[PATCH] D103135: [OpaquePtr] Remove existing support for forward compatibility

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 25 20:13:09 PDT 2021


aeubanks created this revision.
Herald added a subscriber: hiraditya.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

It assumes that PointerType will keep having an optional pointee type,
but we'd like to remove the pointee type in PointerType at some point.

I feel like the current implementation could be simplified anyway,
although perhaps I'm underestimating the amount of work needed
throughout BitcodeReader.

We will still need a side table to keep track of pointee types. This
will be reimplemented at some point.

This is essentially a revert of a4771e9d (which doesn't look like it was
reviewed anyway).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103135

Files:
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Reader/ValueList.cpp
  llvm/lib/Bitcode/Reader/ValueList.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103135.347837.patch
Type: text/x-patch
Size: 43159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210526/394ae118/attachment.bin>


More information about the llvm-commits mailing list