[PATCH] D103100: [AIX] Enable stackprotect feature
Jinsong Ji via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 25 20:07:13 PDT 2021
jsji added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16421
+Value *PPCTargetLowering::getSDagStackGuard(const Module &M) const {
+ if (Subtarget.isAIXABI())
----------------
w2yehia wrote:
> hubert.reinterpretcast wrote:
> > jsji wrote:
> > > jsji wrote:
> > > > hubert.reinterpretcast wrote:
> > > > > There's a number of instances of hard-coded `"__stack_chk_guard"` in what appears to be common code, e.g., in `llvm/lib/Transforms/IPO/Internalize.cpp`. I think those fall within the scope of this patch.
> > > > I think `InternalizePass` is not used by default pass builder.
> > > > I can update it in a later patch if we really want to support it as well.
> > > https://reviews.llvm.org/D103043 just landed so that it is easier to check triple now, I will create a follow up patch later (maybe after a few days when https://reviews.llvm.org/D103043 stabilized). @hubert.reinterpretcast
> > `InternalizePass` is used by LTO afaik; @w2yehia, can you comment?
> Yes, libLTO uses it directly, outside of any pass manager:
> ```
> lto_codegen_compile_to_file
> LTOCodeGenerator::compile_to_file
> LTOCodeGenerator::optimize
> LTOCodeGenerator::applyScopeRestrictions
> llvm::internalizeModule
> InternalizePass(std::move(MustPreserveGV)).internalizeModule(TheModule, CG);
> ```
Thanks Wael.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103100/new/
https://reviews.llvm.org/D103100
More information about the llvm-commits
mailing list