[PATCH] D102995: errorUnsupported should be non-fatal
MJ via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 25 18:21:15 PDT 2021
majiang31312 added a comment.
In D102995#2778674 <https://reviews.llvm.org/D102995#2778674>, @craig.topper wrote:
> "fatal" in the comment means don't diagnose any additional errors and immediately stop. We attempt to recover to detect more errors, but the emitted binary code is likely incorrect. I don't think we can just emit a warning.
>
> The function name says "error" in its name, it should be an error.
Thanks for the explanations, it's reasonable now.
Although “SSE register return with SSE disabled” seems strange as the code did not use SSE directly, it's another problem. I'll close this one now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102995/new/
https://reviews.llvm.org/D102995
More information about the llvm-commits
mailing list