[PATCH] D103129: [llvm-reduce] Don't delete arguments of debug intrinsics

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

should we be skipping all intrinsics? intrinsic signatures should never change right?

and there are a couple comments that seem to indicate that we are only touching definitions, but it looks like we're also touching declarations



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceArguments.cpp:10
 // This file implements a function which calls the Generic Delta pass in order
 // to reduce uninteresting Arguments from defined functions.
 //
----------------
drive by, this looks wrong


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceArguments.cpp:114
 
 /// Counts the amount of arguments in non-declaration functions and prints their
 /// respective name, index, and parent function name
----------------
drive by, this looks wrong


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103129/new/

https://reviews.llvm.org/D103129