[PATCH] D100788: [SystemZ] Support i128 inline asm operands

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 25 16:17:33 PDT 2021


jonpa added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8621
                                "inline asm error: This value type register "
                                "class is not natively supported!");
             return;
----------------
uweigand wrote:
> The wording of the error message now no longer makes sense.   In fact, I think with the new code it no longer can even happen for RC to be null, so I guess the whole error can be removed.
Yes, since RC must be provided I guess this can't happen...

The RC is asserted in createVirtualRegister(), so no need to assert here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100788/new/

https://reviews.llvm.org/D100788



More information about the llvm-commits mailing list