[PATCH] D97430: [SanitizerCoverage] Drop !associated on metadata sections

Tue May 25 15:41:30 PDT 2021

ychen added inline comments.

================
Comment at: llvm/lib/Transforms/Instrumentation/Instrumentation.cpp:76

-Comdat *llvm::GetOrCreateFunctionComdat(Function &F, Triple &T,
-                                        const std::string &ModuleId) {
----------------
Internally, I saw this failure https://github.com/llvm/llvm-project/blob/a6a57f03be40cf2c546805155624a206649092ec/llvm/lib/Linker/LinkModules.cpp#L181 that may be caused by this for a test built with `-fprofile-generate -flto` for ELF. According to the title and description of the patch, that seems an unintended behavior change. Just check in to see if it is obvious how to fix this. Will provide the reproducer once it is available.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97430/new/

https://reviews.llvm.org/D97430