[PATCH] D103118: [SCEV] Compute exit counts for unsigned IVs using mustprogress semantics

[Philip Reames via Phabricator via llvm-commits]

reames created this revision.
reames added reviewers: nikic, mkazantsev.
Herald added subscribers: javed.absar, bollu, hiraditya, mcrosier.
reames requested review of this revision.
Herald added a project: LLVM.

The motivation here is simple loops with unsigned induction variables w/non-one steps.  A toy example would be:
for (unsigned i = 0; i < N; i += 2) { body; }

Given C/C++ semantics, we do not get the nuw flag on the induction variable.  Given that lack, we currently can't compute a bound for this loop.  We can do better for many cases, depending on the contents of "body".

The basic intuition behind this patch is as follows:

- A step which evenly divides the iteration space must wrap through the same numbers repeatedly.  And thus, we can ignore potential cornercases where we exit after the n-th wrap through uint32_max.
- Per C++ rules, infinite loops without side effects are UB.  We already have code in SCEV which relies on this.

Together, these let us conclude that the trip count of this loop must come before unsigned overflow unless the body would form a well defined infinite loop.

A couple notes for reviewers:

- I reused the loop properties code which is overly conservative for this case.  I'll follow up in another patch to generalize it for the actual UB rules.
- We could cache the n(s/u)w facts.  I left that out because doing a pre-patch which cached existing inference showed a lot of diffs I had trouble fully explaining.  I plan to get back to this, but I don't want it on the critical path.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D103118

Files:
  llvm/include/llvm/Analysis/ScalarEvolution.h
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/test/Analysis/ScalarEvolution/lt-overflow.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103118.347791.patch
Type: text/x-patch
Size: 8606 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210525/a14863ea/attachment.bin>