[PATCH] D102733: [Matrix] Factor and distribute transposes across multiplies

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:818
+        dbgs() << "Dump after matrix transpose optimization:\n";
+        Func.dump();
+      }
----------------
int3 wrote:
> int3 wrote:
> > I am getting a link-time failure when doing a local `ninja lld`:
> > 
> > ```
> > Undefined symbols for architecture x86_64:
> >   "llvm::Value::dump() const", referenced from:
> >       (anonymous namespace)::LowerMatrixIntrinsics::Visit() in libLLVMScalarOpts.a(LowerMatrixIntrinsics.cpp.o)
> > ld: symbol(s) not found for architecture x86_64
> > ```
> > 
> > Not sure if/how it passes the buildbots, but it does indeed look like Value.cpp doesn't implement `dump()`.
> (and commenting out this line does indeed fix my local build)
nevermind, I see a fix has just been pushed :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102733/new/

https://reviews.llvm.org/D102733