[llvm] 8e83ff5 - [VectorCombine] Remove unneeded InsertPointGuard (NFCI).

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Tue May 25 09:03:04 PDT 2021


Author: Florian Hahn
Date: 2021-05-25T17:01:05+01:00
New Revision: 8e83ff58c9078c32bbc8d8ea456fa8fc0580761b

URL: https://github.com/llvm/llvm-project/commit/8e83ff58c9078c32bbc8d8ea456fa8fc0580761b
DIFF: https://github.com/llvm/llvm-project/commit/8e83ff58c9078c32bbc8d8ea456fa8fc0580761b.diff

LOG: [VectorCombine] Remove unneeded InsertPointGuard (NFCI).

All users of the builder should set an insert point before using the
builder. There should be no need for using InsertPointGuard here.

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/VectorCombine.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/VectorCombine.cpp b/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
index 50916d0fb3e2..182495615d34 100644
--- a/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
+++ b/llvm/lib/Transforms/Vectorize/VectorCombine.cpp
@@ -910,7 +910,6 @@ bool VectorCombine::scalarizeLoadExtract(Instruction &I) {
   // Replace extracts with narrow scalar loads.
   for (User *U : LI->users()) {
     auto *EI = cast<ExtractElementInst>(U);
-    IRBuilder<>::InsertPointGuard Guard(Builder);
     Builder.SetInsertPoint(EI);
     Value *GEP = Builder.CreateInBoundsGEP(
         FixedVT, Ptr, {Builder.getInt32(0), EI->getOperand(1)});


        


More information about the llvm-commits mailing list