[PATCH] D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 25 08:24:46 PDT 2021


CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added a reviewer: debug-info.
CarlosAlbertoEnciso added a project: debug-info.
Herald added subscribers: hiraditya, mgorny.
CarlosAlbertoEnciso requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fix invalid GUID string generation described by https://bugs.llvm.org/show_bug.cgi?id=50459

The valid format for a GUID is {XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX}
where X is a hex digit (0,1,2,3,4,5,6,7,8,9,A,B,C,D,E,F).

The length of the individual components must be: 8, 4, 4, 4, 12.


https://reviews.llvm.org/D103089

Files:
  llvm/lib/DebugInfo/CodeView/Formatters.cpp
  llvm/test/tools/obj2yaml/COFF/Inputs/test-1.o
  llvm/test/tools/obj2yaml/COFF/Inputs/test-2.o
  llvm/test/tools/obj2yaml/COFF/Inputs/test-3.o
  llvm/test/tools/obj2yaml/COFF/Inputs/test-4.o
  llvm/test/tools/obj2yaml/COFF/Inputs/test-5.o
  llvm/test/tools/obj2yaml/COFF/Inputs/test-6.o
  llvm/test/tools/obj2yaml/COFF/test-1.test
  llvm/test/tools/obj2yaml/COFF/test-2.test
  llvm/test/tools/obj2yaml/COFF/test-3.test
  llvm/test/tools/obj2yaml/COFF/test-4.test
  llvm/test/tools/obj2yaml/COFF/test-5.test
  llvm/test/tools/obj2yaml/COFF/test-6.test
  llvm/unittests/DebugInfo/CodeView/CMakeLists.txt
  llvm/unittests/DebugInfo/CodeView/GUIDFormatTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103089.347651.patch
Type: text/x-patch
Size: 31915 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210525/b6a0432f/attachment.bin>


More information about the llvm-commits mailing list