[PATCH] D102842: [Verifier] Fail on invalid indices for {insert,extract} vector intrinsics

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

The patch looks good thanks @joechrisellis! Just one comment left ...



================
Comment at: llvm/lib/IR/Verifier.cpp:5314
+
+    Assert(VecTy == ResultTy,
+           "experimental_vector_insert vector type must match result type.");
----------------
Hi @joechrisellis could you add a verifier test for this new Assert too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102842/new/

https://reviews.llvm.org/D102842