[PATCH] D101947: GlobalISel: Split ValueHandler into assignment and emission classes

[Konstantin Schwarz via Phabricator via llvm-commits]

kschwarz added inline comments.
Herald added a subscriber: foad.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp:1053
                                                       Info.IsVarArg);
-    CallReturnHandler Handler(MIRBuilder, MRI, MIB, RetAssignFn);
-    if (!handleAssignments(MIRBuilder, InArgs, Handler, Info.CallConv,
-                           Info.IsVarArg))
+    OutgoingValueAssigner Assigner(RetAssignFn);
+    CallReturnHandler Handler(MIRBuilder, MRI, MIB);
----------------
Conceptually, this should be an IncomingValueAssigner, no?
It doesn't make a huge difference for most targets at the moment though, as the assigner doesn't differ too much between incoming and outgoing operands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101947/new/

https://reviews.llvm.org/D101947