[PATCH] D103083: AMDGPU/GlobalISel: Optimize divrem lowering

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 25 05:18:46 PDT 2021


foad added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/udiv.i64.ll:492
 ; GISEL-NEXT:    v_cmp_ne_u32_e32 vcc, 0, v0
+; GISEL-NEXT:    v_cmp_ne_u32_e64 s[4:5], 0, v10
 ; GISEL-NEXT:    v_cndmask_b32_e32 v0, v11, v1, vcc
----------------
Looks like this is actually worse codegen because it's forcing the 64-bit encoding of cmp and cndmask? So maybe my suggestion was not a good idea, sorry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103083/new/

https://reviews.llvm.org/D103083



More information about the llvm-commits mailing list