[PATCH] D102052: [MC][RISCV] Add RISCV MCObjectFileInfo

Philipp Krones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 25 05:05:40 PDT 2021


flip1995 created this revision.
Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, mgorny.
luismarques added a comment.
flip1995 updated this revision to Diff 347640.
flip1995 marked an inline comment as done.
flip1995 published this revision for review.
flip1995 added reviewers: MaskRay, asb.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The banners were copied from other files but not updated to match the new file.

IIRC no one was opposed to this alignment change when we discussed it in a recent RISC-V sync-up call, but let's give it some time for more people to chime in.


flip1995 added a comment.

rebased



================
Comment at: llvm/test/MC/RISCV/align.s:41
 	.p2align 2
-# C-EXT-RELAX-RELOC: R_RISCV_ALIGN - 0x2
-# C-EXT-RELAX-INST:  c.nop
+# If the +c extension is enable, the text section will be 2-byte aligned, so
+# one c.nop instruction is sufficient.
----------------
enable -> enabled


This makes sure, that the text section will have a 2-byte alignment, if
the +c extension is enabled.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102052

Files:
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/lib/MC/MCELFStreamer.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/Target/RISCV/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCObjectFileInfo.cpp
  llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCObjectFileInfo.h
  llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCTargetDesc.cpp
  llvm/test/MC/RISCV/align.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102052.347640.patch
Type: text/x-patch
Size: 7150 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210525/c4924b8e/attachment.bin>


More information about the llvm-commits mailing list