[PATCH] D103027: [VP][SelectionDAG] Add a target-configurable EVL operand type

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 25 04:15:59 PDT 2021


simoll added a comment.

Apart from the nit, this looks good to me.  @rogfer01 ?



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7307
+    if (I == EVLParamPos) {
+      assert(EVLParamVT.isScalarInteger() && EVLParamVT.bitsGE(MVT::i32) &&
+             "Unexpected target EVL type");
----------------
Hoist this up? The assertion does not (actually) depend on the loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103027/new/

https://reviews.llvm.org/D103027



More information about the llvm-commits mailing list