[PATCH] D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`.

Tue May 25 02:53:27 PDT 2021

Esme added a comment.

In D102603#2778965 <https://reviews.llvm.org/D102603#2778965>, @jhenderson wrote:

> Seems to me like this is two separate patches now: 1) adding generic DEBUG printing support to llvm-objdump, then 2) adding XCOFF recognition of debug section types.

Split  the patch and will post the second patch for XCOFF soon.

================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:24
+  - Name:               .text
+    Size:               0x8
+    Flags:              [ STYP_TEXT ]
----------------
jhenderson wrote:
> We probably need to add addresses to some of these too. If memory serves correctly, ELF yaml2obj auto-increments addresses for allocatable sections, if an adderss is not explicitly specified. Perhaps a similar feature could be added to XCOFF yaml2obj in a separate patch? What do you think? In the meantime, the addresses can presumably be done manually here.
>  Perhaps a similar feature could be added to XCOFF yaml2obj in a separate patch?

 Sounds good to me. I will implement the feature for XCOFF yaml2obj in a follow-up work.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102603/new/

https://reviews.llvm.org/D102603