[PATCH] D103033: [LoopStrengthReduce] Ensure that debug intrinsics do not affect LSR's output

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

lgtm (some nits/advices on how-to-reduce-test-case inline)



================
Comment at: llvm/test/Transforms/LoopStrengthReduce/X86/lsr-cond-dbg.ll:108
+!30 = !DILocation(line: 7, column: 13, scope: !23)
+!31 = !{!32, !32, i64 0}
+!32 = !{!"omnipotent char", !33, i64 0}
----------------
!tbaa not needed I guess?


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/X86/lsr-cond-dbg.ll:111
+!33 = !{!"Simple C/C++ TBAA"}
+!34 = !DILocation(line: 7, column: 15, scope: !23)
+!35 = !DILocation(line: 0, scope: !23)
----------------
All these DILocations with the same scope could be represented as one DILocation metadata, so we can get rid of the rest.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103033/new/

https://reviews.llvm.org/D103033