[PATCH] D102978: [WebAssembly] Add TargetInstrInfo::getCalleeOperand
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 25 00:02:54 PDT 2021
aheejin marked 3 inline comments as done.
aheejin added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.cpp:94
case WebAssembly::RET_CALL_INDIRECT_S:
- return MI.getOperand(MI.getNumOperands() - 1);
+ return MI.getOperand(MI.getNumExplicitOperands() - 1);
default:
----------------
djtodoro wrote:
> By doing this, the patch does a bit more then described in the summary. I think this is should be a separate change.
I thought about making it a separate change, but it is hard.
- If we land `DwarfDebug` fix first, it will break all programs with indirect calls and debug info without this `getCalleeOp` fix.
- If we land `getCalleeOp` fix first, there is no way to test that change because `DwarfDebug` is currently the only place we use `getCalleeOp` for indirect calls.
By the way, I fixed the summary to include this fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102978/new/
https://reviews.llvm.org/D102978
More information about the llvm-commits
mailing list