[PATCH] D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 24 23:10:43 PDT 2021


Higuoxing added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:1-5
-# RUN: llvm-objdump --section-headers %p/Inputs/xcoff-section-headers.o | \
-# RUN: FileCheck %s
-
-# RUN: llvm-objdump --section-headers %p/Inputs/xcoff-long-sec-names.o | \
-# RUN: FileCheck --check-prefix=LONG %s
----------------
It looks that `xcoff-section-headers.o` and `xcoff-long-sec-names.o` are useless after this change. Can we remove them?


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/section-headers.test:9-17
+#TYPE:      Sections:
+#TYPE-NEXT: Idx Name          Size     VMA      Type
+#TYPE-NEXT:   0 .text         00000008 00000000 TEXT
+#TYPE-NEXT:   1 .data         00000004 00000000 DATA
+#TYPE-NEXT:   2 .bss          00000000 00000000 BSS
+#TYPE-NEXT:   3 .tdata        00000004 00000000 DATA
+#TYPE-NEXT:   4 .tbss         00000000 00000000 BSS
----------------
Please insert a blank space between `#` and `TYPE-NEXT`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102603/new/

https://reviews.llvm.org/D102603



More information about the llvm-commits mailing list