[PATCH] D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`.

[EsmeYi via Phabricator via llvm-commits]

Esme added a comment.

Addressed some of comments. The patch will be updated after yaml2obj has been fully tested.



================
Comment at: llvm/test/tools/llvm-objdump/ELF/PowerPC/section-headers-debug.test:1
+## Check the `--section-headers` option can print the DEBUG type.
+# RUN: yaml2obj %s -o %t
----------------
jhenderson wrote:
> Rather than having a test dedicated to a specific type field, it would make more sense to have a test that tests all type fields, probably as part of a generic `--section-headers` test. As such, before you add the DEBUG type, I'd recommend writing a new test/expanding an existing test for --section-headers, to test that option thoroughly (a quick skim of test/tools/llvm-objdump suggests there is no such test there, but there is `objdump-sectionheaders.test` in llvm/test/Object, which should probably be moved). This would be a separate patch, prior to this one.
> 
> Another point: the behaviour is not specific to PowerPC, and the test doesn't rely on the PowerPC target being available, so move the test into the ELF directory.
There is generic test, `llvm/test/tools/llvm-objdump/section-headers.test`, so I just expanding it with adding the test for type fields.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102603/new/

https://reviews.llvm.org/D102603