[PATCH] D102732: [CMake] Don't LTO optimize targets that aren't part of any distribution

Mon May 24 20:05:41 PDT 2021

bogner added inline comments.

================
Comment at: llvm/CMakeLists.txt:934

+include(LLVMDistributionSupport)
+
----------------
phosek wrote:
> bogner wrote:
> > phosek wrote:
> > > smeenai wrote:
> > > > Is this moved up just to get the distribution target map built in time for the new use?
> > > Yes, I need `LLVM_DISTRIBUTION_FOR_*` to be populated before creating any targets.
> > I'm seeing test failures if I do `ninja distribution test-depends` and then `ninja check` and I suspect moving this is related.  It's an llvm-config test that fails because `lib/libLLVMObjCMetadata.a` wasn't built though, so it's entirely possible that moving this just exposed a missing dependency somewhere else.
> > 
> > Do you happen to have any insight here?
> Is it possible to reproduce that failure? We're using `ninja distribution` with https://github.com/llvm/llvm-project/blob/main/clang/cmake/caches/Fuchsia-stage2.cmake and haven't seen that issue but our distribution may contain a different set of targets.
This might be a problem on my side. Sorry for the noise.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102732/new/

https://reviews.llvm.org/D102732