[PATCH] D102212: [AMDGPU] Add Optimize VGPR LiveRange Pass.

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 24 18:19:12 PDT 2021


ruiling added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp:190
+
+  SmallSet<Register, 8> KillsInElse;
+
----------------
ruiling wrote:
> critson wrote:
> > Any reason for explicit 8 here?
> > (I am also being reminded not to write explicit sizes in these.)
> No specific reason, will remove it.
SmallSet still needs explicit size, so keep it while removing other explicit size for SmallVector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102212/new/

https://reviews.llvm.org/D102212



More information about the llvm-commits mailing list