[PATCH] D102954: [AMDGPU] Lower kernel LDS into a sorted structure
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 24 15:00:04 PDT 2021
rampitec marked an inline comment as done.
rampitec added inline comments.
================
Comment at: llvm/lib/IR/Value.cpp:535
+void Value::replaceUsesWithIf(Value *New,
+ llvm::function_ref<bool(Use &U)> ShouldReplace) {
----------------
rampitec wrote:
> JonChesterfield wrote:
> > since this hazard affects all the targets, we should probably fix it outside of the amdgpu specific LDS patch
> I can make a separate patch, but the testcase to exploit it here. It needs to see a constant use to fail.
> since this hazard affects all the targets, we should probably fix it outside of the amdgpu specific LDS patch
D103051
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102954/new/
https://reviews.llvm.org/D102954
More information about the llvm-commits
mailing list