[PATCH] D102954: [AMDGPU] Lower kernel LDS into a sorted structure

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/IR/Value.h:313-314
   /// to "V" if the callback ShouldReplace returns true for the given Use.
   /// Unlike replaceAllUsesWith() this function does not support basic block
   /// values or constant users.
   void replaceUsesWithIf(Value *New,
----------------
I guess you need to update the "does not support ... constant users" here?


================
Comment at: llvm/include/llvm/IR/Value.h:321-322
   /// block. 'This's use list is expected to have at least one element.
   /// Unlike replaceAllUsesWith() this function does not support basic block
   /// values or constant users.
   void replaceUsesOutsideBlock(Value *V, BasicBlock *BB);
----------------
... and here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102954/new/

https://reviews.llvm.org/D102954