[PATCH] D103006: [lld][MachO] Add support for LC_DATA_IN_CODE

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 24 15:30:36 PDT 2021


int3 added inline comments.


================
Comment at: lld/test/MachO/data-in-code.s:24
+# BASIC-NEXT:   offset length kind
+# BASIC:        [[#%x,MAIN + 4]] 24 JUMP_TABLE32
+
----------------
nit: it would be clearer to name this variable `TEXT` or `TEXT_ADDR`... having `MAIN` here is a bit misleading since it just so happens that `MAIN` is at text offset zero


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103006/new/

https://reviews.llvm.org/D103006



More information about the llvm-commits mailing list