[PATCH] D102934: [unroll] Use value domain for symbolic execution based cost model

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D102934#2774854 <https://reviews.llvm.org/D102934#2774854>, @nikic wrote:

> I think it would be good to split this into two parts: One that changes the infrastructure to map to Value rather than Constant, making use of the existing SimplifyBinOp fold. And another that replaces constant folding with InstSimplify calls in the places it's not used yet.

If you're happy with the direction, do you mind if I land them without separate review?  i.e. Can I interpret this as an LGTM for the split patches?

I'd mildly prefer not splitting the patches, but I'll do whatever will minimize the review back-and-forth.  :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102934/new/

https://reviews.llvm.org/D102934