[PATCH] D102982: [LoopUnroll] Use smallest exact trip count from any exit
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 24 14:50:06 PDT 2021
reames added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp:1119
+ L->getExitingBlocks(ExitingBlocks);
+ for (BasicBlock *BB : ExitingBlocks) {
+ // Only unroll against latch-dominating exit blocks.
----------------
I would strongly prefer this logic be sunk into the appropriate SCEV accessors. I'm fine with you doing that in a follow up provided you commit to doing so. I'll leave that decision up to you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102982/new/
https://reviews.llvm.org/D102982
More information about the llvm-commits
mailing list