[PATCH] D102462: LLVM Detailed IR tests for introduction of flag -fsanitize-address-detect-stack-use-after-return-mode.

[Kevin Athey via Phabricator via llvm-commits]

kda added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:3358
+    } else {
+      // assert(ClUseAfterReturn == AsanDetectStackUseAfterReturnMode:Always)
+      StackMallocIdx = StackMallocSizeClass(LocalStackSize);
----------------
vitalybuka wrote:
> do you want to uncomment and keep it?
No.  I only meant it as a comment for clarity.


================
Comment at: llvm/test/Instrumentation/AddressSanitizer/stack-poisoning.ll:23
+; CHECK-UAR-NORUNTIME-NOT: label
 ; CHECK-UAR: call i64 @__asan_stack_malloc_4
+; CHECK-UAR-RUNTIME: label
----------------
vitalybuka wrote:
> It would be nice to check for CreateICmpEQ
> But probably D102867 is enough
ack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102462/new/

https://reviews.llvm.org/D102462