[PATCH] D53234: Don't remove COMDATs when internalizing global objects

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 24 13:22:54 PDT 2021


MaskRay added a comment.

I think simply dropping the code can cause some trouble to regular LTO: a relocatable link of a regular LTO may
leverage the suppressed deduplication so that the result object file cannot collide with a
subsequent link with a comdat with the same signature but non-internal.

Posted D103043 <https://reviews.llvm.org/D103043>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53234/new/

https://reviews.llvm.org/D53234



More information about the llvm-commits mailing list