[PATCH] D102999: [WebAssembly] Add NullifyDebugValueLists pass

Mon May 24 11:07:34 PDT 2021

aheejin added inline comments.

================
Comment at: llvm/test/DebugInfo/WebAssembly/dbg-value-list.ll:11
+; CHECK-LABEL: name: dbg_value_list_test
+; CHECK-NOT: DBG_VALUE_LIST
+; CHECK: DBG_VALUE $noreg, $noreg
----------------
dschuff wrote:
> Would it be possible to check that there actually are `DBG_VALUE_LIST`s in the input to the MIR pipeline (perhaps using `-stop-after` or something)? It's not obvious (to me) how the IR below leads to DBG_VALUE_LIST being created and it seems unlikely to be guaranteed.
The presence of `DIArgList` in the first operand of `llvm.dbg.value` generates `DBG_VALUE_LIST`s. I added `BEFORE` and `AFTER` checking in the test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102999/new/

https://reviews.llvm.org/D102999