[PATCH] D102961: [CSSPGO][llvm-profgen] Report samples for untrackable frames.

[Lei Wang via Phabricator via llvm-commits]

wlei accepted this revision.
wlei added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for adding useful debug printer.



================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:150
+                             << format("%" PRIx64, Cur->Address) << " \n";
+      T EmptyStack(Binary);
+      collectSamplesFromFrame(Cur, EmptyStack);
----------------
hoy wrote:
> wlei wrote:
> > Previously we always missed the context from the first frame, right? like `foo @ bar`, it will miss `foo`.
> Exactly. And if `bar` is inlined into `foo`, the issue will cause samples of `bar` to be ignored. For the attached regression test, without the fix, the output profile is empty.
I see, thanks for the fix!!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102961/new/

https://reviews.llvm.org/D102961