[PATCH] D102973: [ELF] Suppress GRP_COMDAT deduplication if the signature symbol is STB_LOCAL
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 24 10:40:10 PDT 2021
MaskRay added a comment.
I raised a Windows PE-COFF example on https://groups.google.com/g/generic-abi/c/2X6mR-s2zoc/m/fc49QKuNBwAJ
In PE-COFF, a COMDAT with a non-external selection symbol does not deduplicate.
I.e. if we disable STB_LOCAL deduplication for COMDAT, compilers can treat ELF and PE-COFF in the same way.
Otherwise, compiler internalization needs to rename the signature specifically for ELF.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102973/new/
https://reviews.llvm.org/D102973
More information about the llvm-commits
mailing list