[PATCH] D103015: [NFC] Add CHECK lines for unordered FP reductions

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 24 10:08:25 PDT 2021


kmclaughlin added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-strict-fadd.ll:131
+; CHECK-UNORDERED: %[[LOAD2:.*]] = load float, float* %[[ARRAYIDX]]
+; CHECK-UNORDERED: vector.ph
+; CHECK-UNORDERED: %[[STEPVEC1:.*]] = call <vscale x 4 x i64> @llvm.experimental.stepvector.nxv4i64()
----------------
david-arm wrote:
> nit: It looks like none of the variables in the `vector.ph` is actually used further down. Maybe it's possible to just delete the whole `vector.ph` block since it's tested in ORDERED case anyway, unless you're now going to add PHIs to the vector.body which show INDUCTION being used?
These weren't being used, though I've kept them here now that I've added check lines for the PHI nodes that use LOAD1/LOAD2


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103015/new/

https://reviews.llvm.org/D103015



More information about the llvm-commits mailing list