[PATCH] D102966: [CVP] Guard against poison in common phji value transform (PR50399)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 24 05:16:37 PDT 2021


spatel added inline comments.


================
Comment at: llvm/test/Transforms/CorrelatedValuePropagation/phi-common-val.ll:142
 entry:
   %sub = sub nsw i32 0, %arg
   %cmp = icmp eq i32 %arg, -2147483648
----------------
Check my understanding (add this test?): if the `sub` does not have `nsw`, then we still allow this transform because the plain `sub` can not create poison and `arg` is not poison?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102966/new/

https://reviews.llvm.org/D102966



More information about the llvm-commits mailing list