[PATCH] D100273: [VectorCombine] Scalarize vector load/extract.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 24 04:51:34 PDT 2021


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:116-119
   // Match source value as load of scalar or vector.
   // Do not vectorize scalar load (widening) if atomic/volatile or under
   // asan/hwasan/memtag/tsan. The widened load may load data from dirty regions
   // or create data races non-existent in the source.
----------------
spatel wrote:
> I didn't check the bot failure, but we dealt with a previous sanitizer failure with an additional predicate here.
I think the issues was that `scalarizeLoadExtract` was called after `foldSingleElementStore`, which may remove  instructions. Should be fixed by 4e8c28b6fbec


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100273/new/

https://reviews.llvm.org/D100273



More information about the llvm-commits mailing list