[PATCH] D93838: [SCCP] Add Function Specialization pass

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/FunctionSpecialization.cpp:777
+  auto &TrackedFuncs = Solver.getArgumentTrackedFunctions();
+  SmallVector<Function *, 16> FuncDecls(TrackedFuncs.begin(),
+                                        TrackedFuncs.end());
----------------
fhahn wrote:
> Are those declarations? Shouldn't we only track functions with definitions?
Yeah, these should be functions with definitions. There's a `F.isDeclaration()` check earlier in this function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93838/new/

https://reviews.llvm.org/D93838